Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3446 reference version missing from parameter hash #3463

Merged
merged 13 commits into from
Mar 18, 2022
Merged

Issue #3446 reference version missing from parameter hash #3463

merged 13 commits into from
Mar 18, 2022

Conversation

punktilious
Copy link
Collaborator

@punktilious punktilious commented Mar 14, 2022 •
edited
Loading

Includes fixes for the following issues:

@punktilious
issue #3446 reference version missing from parameter hash
56abc43 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@punktilious
issue #3446 copyright update
46e88ad 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@punktilious punktilious requested review from lmsurpre and tbieste March 14, 2022 13:02
@punktilious punktilious changed the title Issue 3446 Issue #3446 reference version missing from parameter hash Mar 14, 2022
lmsurpre
lmsurpre approved these changes Mar 14, 2022
View reviewed changes
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@punktilious
issue #3446 added test for token version parameter hash
83ea787 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@punktilious
issue #3446 param hash must flip ByteBuffer before reading
8bd65c5 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@punktilious
issue #3439 handle null data value for search/history after erase
49155a6 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@punktilious
issue #3439 system tests for handling null data after erase
699a412 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@punktilious
Merge remote-tracking branch 'origin/HEAD' into issue-3446
ef4baed
@punktilious
issue #3416 prevent payload config falling back to default
543c068 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@punktilious
issue #3416 unit tests for payload config fallback
93ac830 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@punktilious
issue #3416 copyright
c34937e 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@punktilious
issue #3416 only filter out null resource when data is requested
659670e 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@punktilious
issue #3446 update copyright year
49dfef2 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@punktilious
issue #3439 removed debug println
e733cda 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
tbieste
tbieste approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@tbieste tbieste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmsurpre lmsurpre merged commit 9e93d89 into main Mar 18, 2022
@lmsurpre lmsurpre deleted the issue-3446 branch March 18, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmsurpre lmsurpre lmsurpre approved these changes

@tbieste tbieste tbieste approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@punktilious @lmsurpre @tbieste