Support 'RGBA' mode images by converting to 'RGB' #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MLnick
changed the title
|
cc @zuhito |
|
It looks great! After merging this, I will use PNG files using this Docker image. |
ptitzler
suggested changes
Mar 5, 2019
|
Created a "test" image by converting one of our asset files from jpeg to tiff. File is ZIPped because GH can't handle TIFF. |
|
TIFF should be supported with this PR - I can add a test case.
Technically all formats loadable by Pillow are supported. There’s other
ones but JPG, PNG and TIFF are really the common ones.
…On Tue, 5 Mar 2019 at 18:32, Patrick Titzler ***@***.***> wrote:
Created a "test" image by converting one of our asset files from jpeg to
tiff. File is ZIPped because GH can't handle TIFF.
baby-bear.zip
<https://github.com/IBM/MAX-Human-Pose-Estimator/files/2931803/baby-bear.zip>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA_SB4s3iO9OLbCIU54P8vaWvL5Q3ZYxks5vTpwIgaJpZM4besDQ>
.
|
bdwyer2
approved these changes
Mar 5, 2019
|
Added test case for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12, #13