Update tests to use Junit 5 #252
Open
+7,073
−17,863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonkatonica
force-pushed
the
katonica/feature/migratetojunit5
branch
from
82c68a2
to
d9f8b81
Compare
jasonkatonica
requested review from
taoliult,
KostasTsiounis,
johnpeck-us-ibm and
JinhangZhang
jasonkatonica
force-pushed
the
katonica/feature/migratetojunit5
branch
from
d9f8b81
to
3235a02
Compare
johnpeck-us-ibm
approved these changes
Oct 17, 2024
jasonkatonica
force-pushed
the
katonica/feature/migratetojunit5
branch
from
3235a02
to
9700266
Compare
|
Rebased on latest |
jasonkatonica
force-pushed
the
katonica/feature/migratetojunit5
branch
2 times, most recently
from
a6a0dcb
to
21ba67f
Compare
|
Rebased on latest main branch. |
jasonkatonica
force-pushed
the
katonica/feature/migratetojunit5
branch
from
21ba67f
to
ed647e9
Compare
|
Rebased on latest |
jasonkatonica
force-pushed
the
katonica/feature/migratetojunit5
branch
from
ed647e9
to
381e16e
Compare
|
Rebased on latest code. |
jasonkatonica
force-pushed
the
katonica/feature/migratetojunit5
branch
4 times, most recently
from
bb3f12e
to
8260be2
Compare
jasonkatonica
force-pushed
the
katonica/feature/migratetojunit5
branch
from
8260be2
to
8a27e08
Compare
Tests have been updated to use Junit5. Changes made include: - Removing the `junit-vintage-engine` dependency. This is no longer in use given all tests now make use of Junit 5. - Tests are sorted by alphabetical in test suites. - Tests no longer need to extend `junit.framework.TestCase`. - Tests are explicitly declared with the `@Test` annotation. - Test constructors have been removed. Arguments to the base tests are now sent using getters and setters. This is typically only used for setting providers, algorithms, or key sizes in tests. - Various `main()` methods of tests were removed as they are no longer in use. Tests can be run using various Junit 5 test execution tools such as IDEs, command line tools, and `mvn` surefire which is already in place in this project. - `BaseTest` was removed as it is no longer in use and represents a Junit 3 test. A new `BaseTestJunit5` test has been created to represent the new base for the test hierarchy. - The concept of warming up a test has been removed from a few locations. Tests are not expected to act as performance tests. - Copyrights were updated. - Various empty comment blocks were removed. - Some tests were not executing using the expected provider since the incorrect `Utils` class was in use. This was corrected to use the correct class. - Tests `TestAESGCM_192`, `TestAESGCM_256`, and `TestRSA_4096` were added to the `OpenJCEPlus` and `OpenJCEPlusFIPS` provider test suites. - Tests `TestECDHInteropBC`, `TestRSATypeCheckEnabled`, `TestAES_192`, and `TestAES_256` were added to the `OpenJCEPlus` provider test suite - Tests `TestAES_192` and `TestAES_256` were removed from the `TestMultithreadFIPS` since these tests take a long period of time to complete. Coverage functionally is still maintained since they are executed as part of the `OpenJCEPlusFIPS` provider tests. - Increased timeouts associated with tests `TestMultithreadFIPS` and `TestMultithread`. Signed-off-by: Jason Katonica <katonica@us.ibm.com>
jasonkatonica
force-pushed
the
katonica/feature/migratetojunit5
branch
from
8a27e08
to
99241c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests have been updated to use Junit5. Changes made include:
junit-vintage-enginedependency. This is no longer in use given all tests now make use of Junit 5.junit.framework.TestCase.@Testannotation.main()methods of tests were removed as they are no longer in use. Tests can be run using various Junit 5 test execution tools such as IDEs, command line tools, andmvnsurefire which is already in place in this project.BaseTestwas removed as it is no longer in use and represents a Junit 3 test. A newBaseTestJunit5test has been created to represent the new base for the test hierarchy.Utilsclass was in use. This was corrected to use the correct class.TestAESGCM_192,TestAESGCM_256, andTestRSA_4096were added to theOpenJCEPlusandOpenJCEPlusFIPSprovider test suites.TestECDHInteropBC,TestRSATypeCheckEnabled,TestAES_192, andTestAES_256were added to theOpenJCEPlusprovider test suiteTestAES_192andTestAES_256were removed from theTestMultithreadFIPSsince these tests take a long period of time to complete. Coverage functionally is still maintained since they are executed as part of theOpenJCEPlusFIPSprovider tests.TestMultithreadFIPSandTestMultithread.