Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement timeout handling #111

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Implement timeout handling #111

merged 2 commits into from
Oct 5, 2022

Conversation

timbuchwaldt
Copy link
Collaborator

@timbuchwaldt timbuchwaldt commented Sep 12, 2022

This fixes #110.

Signed-off-by: Tim Buchwaldt <tim@buchwaldt.ws>
@timbuchwaldt timbuchwaldt changed the title WIP: Implement timeout handling Implement timeout handling Sep 15, 2022
@timbuchwaldt
Copy link
Collaborator Author

@No9 ready for your input :)

This adds a test, sets the default timeout to 120s and fixes the
implementation to actually exit the process.

Signed-off-by: Tim Buchwaldt <tim@buchwaldt.ws>
@No9
Copy link
Collaborator

No9 commented Sep 15, 2022

Travelling today but from what I can see on the mobile that looks cleaner than I was expecting.
I'll take a closer look over the next few days.

@timbuchwaldt
Copy link
Collaborator Author

Sure, no hurry, safe travels!

Copy link
Collaborator

@No9 No9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean implementation and the integration tests pass

@No9 No9 merged commit f38a2aa into IBM:main Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible bug - coredump hangs
2 participants