Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variables to Chart for Timeout and No Compression #116

Merged
merged 5 commits into from
Nov 25, 2022

Conversation

No9
Copy link
Collaborator

@No9 No9 commented Nov 6, 2022

@timbuchwaldt I've moved the setting of the timeout out of the composer arguments and into the chart so it's setup as an environment variable called TIMEOUT.
867b4a7#diff-41993b17674b907eda9d68b0aabdb0fe6cca65177bc94b74cba88ffc23932dc2R30

@stonemaster The disable compression -D has also been removed and added an environment variable called COMPRESSION to the composer config
867b4a7#diff-41993b17674b907eda9d68b0aabdb0fe6cca65177bc94b74cba88ffc23932dc2R31

The image is building here: https://quay.io/repository/icdh/core-dump-handler/build/b50f285f-8120-4a84-ad7e-beb3358afe97

Once that is compete you should be able to checkout the schema-update branch and validate.

Let me know if you have any comments suggested changes.

Thanks

[Edit]
Baseline integration tests pass.

No9 added 5 commits November 6, 2022 16:55
Signed-off-by: Anthony Whalley <anton@venshare.com>
Signed-off-by: Anthony Whalley <anton@venshare.com>
Signed-off-by: Anthony Whalley <anton@venshare.com>
Signed-off-by: Anthony Whalley <anton@venshare.com>
Signed-off-by: Anthony Whalley <anton@venshare.com>
@timbuchwaldt
Copy link
Collaborator

Hey! Sorry for the delay, was away on vacation and a business trip. Looks great, I'll have a look when I can roll it out to test!

@timbuchwaldt
Copy link
Collaborator

timbuchwaldt commented Nov 24, 2022

Sorry for the long delay again, this was some turbulent time :D When trying to access the built image it asks for login. I assume that's something IBM-internal?

@No9
Copy link
Collaborator Author

No9 commented Nov 25, 2022

Do you mean that when you are running docker pull quay.io/icdh/core-dump-handler:schema-updates you are now getting challenged for a password? I didn't hear of a change on policy on quay.

@timbuchwaldt
Copy link
Collaborator

Oh wow never mind, I mindlessly clicked the link and was prompted for a login M)

@No9
Copy link
Collaborator Author

No9 commented Nov 25, 2022

Cool - You should just(tm) be able to check out the branch apply your settings and run it

@timbuchwaldt
Copy link
Collaborator

timbuchwaldt commented Nov 25, 2022 via email

@No9
Copy link
Collaborator Author

No9 commented Nov 25, 2022

Great stuff - I'll take that as a go

@No9
Copy link
Collaborator Author

No9 commented Nov 25, 2022

@timbuchwaldt Can you give an ok with the review button when you have a minute please.

@No9 No9 merged commit 8576047 into main Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants