-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add environment variables to Chart for Timeout and No Compression #116
Conversation
Signed-off-by: Anthony Whalley <anton@venshare.com>
Signed-off-by: Anthony Whalley <anton@venshare.com>
Signed-off-by: Anthony Whalley <anton@venshare.com>
Signed-off-by: Anthony Whalley <anton@venshare.com>
Signed-off-by: Anthony Whalley <anton@venshare.com>
Hey! Sorry for the delay, was away on vacation and a business trip. Looks great, I'll have a look when I can roll it out to test! |
Sorry for the long delay again, this was some turbulent time :D When trying to access the built image it asks for login. I assume that's something IBM-internal? |
Do you mean that when you are running |
Oh wow never mind, I mindlessly clicked the link and was prompted for a login M) |
Cool - You should just(tm) be able to check out the branch apply your settings and run it |
It’s running on one of our clusters now.Sent from my iPhoneOn 25. Nov 2022, at 18:58, Anton Whalley ***@***.***> wrote:
Cool - You should just(tm) be able to check out the branch apply your settings and run it
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Great stuff - I'll take that as a go |
@timbuchwaldt Can you give an ok with the review button when you have a minute please. |
@timbuchwaldt I've moved the setting of the timeout out of the composer arguments and into the chart so it's setup as an environment variable called
TIMEOUT
.867b4a7#diff-41993b17674b907eda9d68b0aabdb0fe6cca65177bc94b74cba88ffc23932dc2R30
@stonemaster The disable compression
-D
has also been removed and added an environment variable calledCOMPRESSION
to the composer config867b4a7#diff-41993b17674b907eda9d68b0aabdb0fe6cca65177bc94b74cba88ffc23932dc2R31
The image is building here: https://quay.io/repository/icdh/core-dump-handler/build/b50f285f-8120-4a84-ad7e-beb3358afe97
Once that is compete you should be able to checkout the schema-update branch and validate.
Let me know if you have any comments suggested changes.
Thanks
[Edit]
Baseline integration tests pass.