Scheduler fix #121
Merged
Scheduler fix #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Whalley <anton@venshare.com>
Signed-off-by: Anton Whalley <anton@venshare.com>
Signed-off-by: Anton Whalley <anton@venshare.com>
Signed-off-by: Anton Whalley <anton@venshare.com>
Signed-off-by: Anton Whalley <anton@venshare.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to updates in the scheduler the scheduler was failing on the first call to the scheduled poll.
This wasn't caught in integration testing as the server would restart the agent pod and this would initiate a sweep that would allow the test to pass.
This update now maps to the implementation in the tokio-cron-scheduler examples and uses a loop to prevent the agent from falling through while it waits for the async handles to complete.