Chart value "composer.logLength" doesn't affect. #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for this @oniku-2929 good catch. If you can sign the commit as per https://github.com/IBM/core-dump-handler/pull/139/checks?check_run_id=12098075677 |
Signed-off-by: oniku2929 <o29n1ku2ku@gmail.com>
oniku-2929
force-pushed
the
fix/logLength
branch
from
4b91491 to
90b4971
Compare
|
@No9 |
No9
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @No9.
I found that the chart value
composer.logLengthdoesn't affect to the composer's actual setting valueLOG_LENGTH.Then it's just used the default value 500 even though I specify it like this.
Because core-dump-agent doesn't read the environment variable "COMP_LOG_LENGTH" passed from
daemonset.yaml.