fix hardcoded s3 creds #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No9
reviewed
Mar 12, 2022
No9
reviewed
Mar 12, 2022
No9
reviewed
Mar 12, 2022
charts/core-dump-handler/README.md
Outdated
| } | ||
| ] | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Can you also add a sample command you used to install the chart.
Want to capture how it works with the schema validation
There was a problem hiding this comment.
I'm not using the chart.
It doesn't fit our gitops-only paradigm.
I render the chart offline using helm template and then install it through fluxcd2
No9
requested changes
Mar 12, 2022
use a node or config based creds when not supplied explicitly
|
Thanks again for this I'll merge this PR and sort the fmt issue as part of the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use a node or config based creds when not supplied explicitly
fixes: #75