Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: increase CPU request to 1 and disable concurrent builds #688

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

emlaver
Copy link
Contributor

@emlaver emlaver commented Jan 11, 2024

Checklist

  • Added tests for code changes or test/build only changes
  • Updated the change log file (CHANGES.md) or test/build only changes
  • Completed the PR template below:

Description

The fatal error unit tests failed right before the merge of #662.
This most likely happened when our kube CI resources were strained and being throttled . Increasing the CPU request to 1 and disabling concurrent builds should hopefully allow for enough resources so that the test suite doesn't time out.

fixes i316

Approach

Schema & API Changes

Security and Privacy

Testing

Monitoring and Logging

Signed-off-by: Esteban Laver <10552966+emlaver@users.noreply.github.com>
@emlaver emlaver self-assigned this Jan 11, 2024
Copy link
Member

@ricellis ricellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
If the problem persists we could remove Node 21 from the matrix to reduce the resources needed. We only support the LTS versions of Node anyway.

@emlaver emlaver merged commit 19eee3f into main Jan 12, 2024
4 checks passed
@emlaver emlaver deleted the 316-update-kube-resources branch January 12, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants