Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix snapshot version format #719

Merged
merged 1 commit into from
Feb 14, 2024
Merged

build: fix snapshot version format #719

merged 1 commit into from
Feb 14, 2024

Conversation

ricellis
Copy link
Member

Checklist

  • Added tests for code changes or test/build only changes - build
  • Updated the change log file (CHANGES.md) or test/build only changes - build
  • Completed the PR template below:

Description

Fix snapshot version format

Fixes part of i303

Approach

Change the build identifier from .N to -N so that on release builds where there is no -SNAPSHOT suffix we still get a valid identifier.

Schema & API Changes

  • "No change"

Security and Privacy

  • "No change"

Testing

  • N/A build or packaging only changes

Monitoring and Logging

  • "No change"

@ricellis ricellis self-assigned this Feb 14, 2024
@ricellis ricellis merged commit c426f54 into main Feb 14, 2024
4 checks passed
@ricellis ricellis deleted the i303-fix-snapshot-version branch February 14, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlaver emlaver emlaver approved these changes

@eiri eiri eiri approved these changes

Assignees

@ricellis ricellis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ricellis @eiri @emlaver