Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed upper bound of var #45

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Fixed upper bound of var #45

merged 1 commit into from
Jul 7, 2021

Conversation

justanotherlad
Copy link
Contributor

@justanotherlad justanotherlad commented Jul 2, 2021 •
edited by naoise-h
Loading

Changed upper bound of variance from (upper - lower) ** 2 to ((upper - lower) ** 2) / 4 guaranteed by Popoviciu's inequality

Closes #44

@justanotherlad
Fixed upper bound of var
c7e2c6e 
Changed upper bound of variance from (upper - lower) ** 2  to ((upper - lower) ** 2) / 4  guaranteed by Popoviciu's inequality
@justanotherlad justanotherlad mentioned this pull request Jul 2, 2021
Closed
naoise-h
naoise-h approved these changes Jul 7, 2021
View reviewed changes
Copy link
Member

@naoise-h naoise-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution.

@naoise-h naoise-h merged commit 63bb074 into IBM:main Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naoise-h naoise-h naoise-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upper Bound of _var() in diffprivlib/tools/utils.py
2 participants
@justanotherlad @naoise-h