Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrap full validation errors instead of just their message #232

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

pyrooka
Copy link
Member

@pyrooka pyrooka commented Dec 5, 2024

This PR contains a simple adjustment to error handling of the struct field validation.
Previously only the string representation of the error was included in the returned
SDKError, but an upcoming change to the CLI plugins requires the actual error
object, because it contains valuable information.

Signed-off-by: Norbert Biczo <pyrooka@users.noreply.github.com>
@pyrooka pyrooka requested review from dpopp07 and padamstx December 5, 2024 21:29
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This is clearly an example of "addition by subraction" 😂

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@pyrooka pyrooka merged commit 1bfb146 into main Dec 12, 2024
4 checks passed
@pyrooka pyrooka deleted the nb/wrapping-validation-errors branch December 12, 2024 14:20
ibm-devx-sdk pushed a commit that referenced this pull request Dec 12, 2024
## [5.18.2](v5.18.1...v5.18.2) (2024-12-12)

### Bug Fixes

* wrap full validation errors instead of just their message ([#232](#232)) ([1bfb146](1bfb146))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 5.18.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants