Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs release 1.8.0 csi 3573 external log collection (PR2) #418

Merged
merged 26 commits into from
Dec 14, 2021
Merged

Docs release 1.8.0 csi 3573 external log collection (PR2) #418

merged 26 commits into from
Dec 14, 2021

Conversation

rivkap
Copy link
Member

@rivkap rivkap commented Dec 12, 2021

No description provided.

@rivkap rivkap mentioned this pull request Dec 12, 2021
Merged
@oriyarde oriyarde mentioned this pull request Dec 12, 2021
Merged
ArbelNathan
ArbelNathan approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@ArbelNathan ArbelNathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

oriyarde
oriyarde approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@oriyarde oriyarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not our end goal, but good enough for now

roysahar
roysahar reviewed Dec 13, 2021
View reviewed changes
Copy link
Contributor

@roysahar roysahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rivkap I added some comments.

roysahar
roysahar approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@roysahar roysahar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @rivkap

oriyarde
oriyarde approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@oriyarde oriyarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rivkap rivkap merged commit 59daf24 into docs_release-1.8.0 Dec 14, 2021
@rivkap rivkap deleted the docs_release-1.8.0-CSI-3573_external_log_collection branch December 14, 2021 14:23
rivkap added a commit that referenced this pull request Dec 15, 2021
@rivkap
Docs release 1.8.0 (#415)
2143122 
1.8.0 v documentation updates (CSI-3506)
including: 
* CSI-3242: HyperSwap feature updates (#397)
* Docs release 1.8.0 csi-3528 general updates (#403)
* Adding CSI-3507 NVMe-FC information
* minor updates
* Docs release 1.8.0 CSI 3512 svc space efficiency updates (#411)
* Docs release 1.8.0 csi 3508 1.8.0 v updates 2 (#416)
* updated A9K min support
per new min support req
* Docs release 1.8.0 csi 3573 external log collection (#407)
-added healthport to whatsnew/changelog
* Docs release 1.8.0 csi 3573 external log collection (PR2) (#418)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roysahar roysahar roysahar approved these changes

@ArbelNathan ArbelNathan ArbelNathan approved these changes

@oriyarde oriyarde oriyarde approved these changes

@tyichye19 tyichye19 Awaiting requested review from tyichye19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rivkap @roysahar @ArbelNathan @oriyarde