Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OperandConfig with value reference #1576

Merged
merged 4 commits into from
Nov 2, 2023

Conversation

Daniel-Fan
Copy link
Contributor

@Daniel-Fan Daniel-Fan commented Nov 1, 2023

Please merge this PR ONLY AFTER ODLM's PR is merged: IBM/operand-deployment-lifecycle-manager#990

Update

  1. KeyCloak Route is created by ODLM directly, and support value reference on following fields.
    • spec.host: Optional, user could specify custom hostname by updating .data.keycloak_route_name in ibm-cpp-config ConfigMap
    • spec.tls.caCertificate, spec.tls.certificate, spec.tls.key: Optional, user could specify custom certificate by creating secret keycloak-custom-tls-secret
    • spec.tls.destinationCACertificate: Required, it is referencing the CA cert from cs-keycloak-tls-secret
  2. KeyCloak CR is created by ODLM, and support value reference on following fields.
    • spec.hostname.hostname: Required, it is reference the .spec.host from keycloak Route
    • spec.ingress.enabled: false to turn off KeyCloak operator creating Ingress Object, so it will use Route directly.
  3. EDB Cluster CR is created by ODLM directly, and support value reference on following fields.
    • spec.imageName: Required.
      • The default value is icr.io/cpopen/edb/postgresql:14.9@sha256:90136074adcbafb5033668b07fe1efea9addf0168fa83b0c8a6984536fc22264.
      • And if the ConfigMap cloud-native-postgresql-image-list exists in operator namespace, it will reference .data.ibm-postgresql-14-operand-image
      • And user could specify .data.edb-keycloak-operand-image in ibm-cpp-config ConfigMap to override above default EDB image setting.

Signed-off-by: Daniel Fan <fanyuchensx@gmail.com>
Signed-off-by: Daniel Fan <fanyuchensx@gmail.com>
Signed-off-by: Daniel Fan <fanyuchensx@gmail.com>
Signed-off-by: Daniel Fan <fanyuchensx@gmail.com>
Copy link
Contributor

@YCShen1010 YCShen1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daniel-Fan, YCShen1010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Daniel-Fan,YCShen1010]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit 0a77f38 into IBM:master Nov 2, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants