Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make block e2e compatible with main branch + Fix bugs #110

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

prankulmahajan
Copy link
Member

@prankulmahajan prankulmahajan commented Jul 10, 2024

  • Update ginkgo version to 2.17.2
  • Fix issues in baseutils due to the updated k8s packages
  • Fix issue where unable to create ROKS cluster when latest version is selected
  • Give msg to slack in case cluster creation fails
  • Update README

Updates in jenkins config:

  • Updated kubectl to 1.29
  • Updated ginkgo to match 2.17.2
  • Fix issue where jenkins job show success even if there are cluster creation issues.
  • Fix issue where cluster deletion isn't triggered if ginkgo tests fails
  • Catch SIGTERM signal i.e a jenkins job is terminated manually, it will trigger a cleanup of cluster first before existing
  • Update timeout from 120 to 180 min. (Currently 120 min there is a case when cluster deletion is skipped)
  • Fix issue where region other that us-south was allowed to enter when stage env was selected.

@prankulmahajan
Copy link
Member Author

prankulmahajan commented Jul 10, 2024

Negative tests done:

  • Created IKS 1.30 prod cluster with image: nginx -> Expected jenkins job to fail as tests wont be able to pull public image. Also ensure cluster is deleted
  • Security group pending issue -> Not able to replicate
  • If given wrong version of IKS/ROKS, jenkins job should be marked as Failed

Positive tests done:

  • IKS 1.30
  • ROKS 4.15

@prankulmahajan prankulmahajan changed the title Make block e2e compatible with main branch Make block e2e compatible with main branch + Fix bugs Jul 10, 2024
Copy link
Member

@sameshai sameshai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prankulmahajan prankulmahajan merged commit 32ea86e into master Jul 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants