Fix JSONTop() == 1 and JSONbot() == 0 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shinnar
requested changes
Jul 8, 2024
kmichel-aiven
force-pushed
the
kmichel-fix-top-equality
branch
from
2ed4ed4 to
37f4eb1
Compare
The == operator in `is_top` and `is_bot` causes type confusion when comparing `JSONTop()` and `JSONbot()` values. Fix it by using identity test instead of equality.
kmichel-aiven
force-pushed
the
kmichel-fix-top-equality
branch
from
37f4eb1 to
5d0d311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The == operator in
is_topandis_botcauses type confusion when comparingJSONTop()andJSONbot()values.Fix it by using identity test instead of equality.