Skip to content

Conversation

@rakdutta
Copy link
Collaborator

@rakdutta rakdutta commented Oct 29, 2025

Issue #1328

This PR enhances how tool output schemas are managed, validated, and displayed. It adds support for optional schemas, structured result validation, and UI improvements for easier schema editing and review.

Backend:

  • Added _extract_and_validate_structured_content for schema-based result validation using jsonschema.
  • Updated tool logic to store output_schema as None when not provided.
  • Added structured_content to ToolResult for validated data and improved logging for schema changes.

Frontend:

  • Enhanced admin UI to handle optional schemas, manage read-only states, and display validation errors clearly.
  • Updated placeholder text to better reflect the expected schema format.

Verification:
Verified tool behavior in MCP Inspector for both cases — with and without output schema. Functionality works as expected.

@rakdutta rakdutta force-pushed the issue_1328_outputschema branch 2 times, most recently from 0ca6d96 to 5517c3d Compare November 3, 2025 05:39
@rakdutta rakdutta marked this pull request as ready for review November 3, 2025 06:04
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
Signed-off-by: rakdutta <rakhibiswas@yahoo.com>
@crivetimihai crivetimihai force-pushed the issue_1328_outputschema branch from a73cdaa to b9b6229 Compare November 4, 2025 10:18
@crivetimihai crivetimihai merged commit 1786dcd into main Nov 4, 2025
45 checks passed
@crivetimihai crivetimihai deleted the issue_1328_outputschema branch November 4, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants