Skip to content

fix: local network address translation in discovery module #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2025
Merged

fix: local network address translation in discovery module #767

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions mcpgateway/federation/discovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
import asyncio
from dataclasses import dataclass
from datetime import datetime, timedelta, timezone
import ipaddress
import os
import socket
from typing import Dict, List, Optional
Expand Down Expand Up @@ -219,8 +220,10 @@ def _get_local_addresses(self) -> List[str]:
# Get all network interfaces
for iface in socket.getaddrinfo(socket.gethostname(), None):
addr = iface[4][0]
# Skip localhost
if not addr.startswith("127."):
ip_obj = ipaddress.ip_address(addr)
is_ipv4 = isinstance(ip_obj, ipaddress.IPv4Address)
# Skip localhost and non ipv4 addresses
if is_ipv4 and not addr.startswith("127."):
addresses.append(addr)
except Exception as e:
logger.warning(f"Failed to get local addresses: {e}")
Expand Down
Loading