Skip to content

Issue 587/rest tool error #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2025
Merged

Issue 587/rest tool error #778

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb11043
added params extraction from url logic
nmveeresh Aug 18, 2025
1c6d16c
added params extraction from url logic
nmveeresh Aug 18, 2025
f78be73
Rebase and lint / test
crivetimihai Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions mcpgateway/services/tool_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import re
import time
from typing import Any, AsyncGenerator, Dict, List, Optional
from urllib.parse import parse_qs, urlparse
import uuid

# Third-Party
Expand Down Expand Up @@ -756,6 +757,15 @@ async def invoke_tool(self, db: Session, name: str, arguments: Dict[str, Any], r
else:
raise ToolInvocationError(f"Required URL parameter '{param}' not found in arguments")

# --- Extract query params from URL ---
parsed = urlparse(final_url)
final_url = f"{parsed.scheme}://{parsed.netloc}{parsed.path}"

query_params = {k: v[0] for k, v in parse_qs(parsed.query).items()}

# Merge leftover payload + query params
payload.update(query_params)

# Use the tool's request_type rather than defaulting to POST.
method = tool.request_type.upper()
if method == "GET":
Expand Down
Loading