Skip to content

Conversation

rakdutta
Copy link
Collaborator

The name field is now a calculated field and should not be manually updated.
This PR removes the redundant code block in tool_service.py that previously handled name updates:

if tool_update.name is not None:
    tool.name = tool_update.name

Key Changes

  • Removed explicit name assignment during tool update.
  • Ensures consistency by relying only on calculated logic for the name field.
  • Prevents unintended overwrites of the computed name.

Signed-off-by: RAKHI DUTTA <rakdutta@in.ibm.com>
Copy link
Member

@crivetimihai crivetimihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and tested

@crivetimihai crivetimihai merged commit 30bcde0 into IBM:main Aug 21, 2025
36 of 37 checks passed
vk-playground pushed a commit to vk-playground/mcp-context-forge that referenced this pull request Sep 14, 2025
Signed-off-by: RAKHI DUTTA <rakdutta@in.ibm.com>
Co-authored-by: RAKHI DUTTA <rakdutta@in.ibm.com>
vk-playground pushed a commit to vk-playground/mcp-context-forge that referenced this pull request Sep 14, 2025
Signed-off-by: RAKHI DUTTA <rakdutta@in.ibm.com>
Co-authored-by: RAKHI DUTTA <rakdutta@in.ibm.com>
vk-playground pushed a commit to vk-playground/mcp-context-forge that referenced this pull request Sep 16, 2025
Signed-off-by: RAKHI DUTTA <rakdutta@in.ibm.com>
Co-authored-by: RAKHI DUTTA <rakdutta@in.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants