Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for react router 3 #2

Closed
wants to merge 1 commit into from

Conversation

phpnode
Copy link

@phpnode phpnode commented Nov 1, 2016

I just copied the solution from the redux router repo - reactjs/react-router-redux#476

@alisd23
Copy link
Collaborator

alisd23 commented Nov 1, 2016

Thanks for this, surprised it's so easy! Could you also bump up the react-router version in the package.json to test it works with that version?

@alisd23
Copy link
Collaborator

alisd23 commented Nov 3, 2016

Closing in favor of #3.

Decided to just bump a new major version (3 - in line with react-router) and stop supporting v2 because:

  • The breaking changes from v2 to v3 aren't huge so devs really should be upgrading anyway.
  • React Router won't be maintaining v2 anymore, it'll all be on v3.

@alisd23 alisd23 closed this Nov 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants