Drop support for NAPI 7 and below #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to only build for one NAPI version instead of 4 and removes a separate code path for NAPI versions older than 6. We technically don't use anything newer than 6, but may as well go to 8 since that supports all Node.js versions we care about (and even some we don't). https://nodejs.org/api/n-api.html#node-api-version-matrix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to only build for one NAPI version instead of 4 and removes a separate code path for NAPI versions older than 6. We technically don't use anything newer than 6, but may as well go to 8 since that supports all Node.js versions we care about (and even some we don't).
https://nodejs.org/api/n-api.html#node-api-version-matrix