feat: add support for compressing request bodies #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpopp07
force-pushed
the
dp/gzip-requests
branch
from
b612cc0 to
620eccd
Compare
padamstx
requested changes
Oct 4, 2020
dpopp07
force-pushed
the
dp/gzip-requests
branch
from
620eccd to
1f18fe3
Compare
|
All feedback should now be addressed |
padamstx
requested changes
Oct 5, 2020
a flag can be passed to the BaseService that will enable gzip compression on the request body data
dpopp07
force-pushed
the
dp/gzip-requests
branch
from
1f18fe3 to
eab2ccd
Compare
jorge-ibm
approved these changes
Oct 6, 2020
ibm-devx-automation
pushed a commit
that referenced
this pull request
Oct 6, 2020
# [2.7.0](v2.6.0...v2.7.0) (2020-10-06) ### Features * add support for compressing request bodies ([#111](#111)) ([7692d71](7692d71))
|
🎉 This PR is included in version 2.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A flag can now be passed to the BaseService that will enable gzip compression on the request body data. This flag is passed down to the RequestWrapper class where the compression code lives. Note that no code needs to be changed in the BaseService - the options passed into its constructor will be carried through to the RequestWrapper. In the generated code, I am planning on attaching the flag to the options passed into the BaseService constructor.
If there is a problem during compression, the code moves alone with the request, just uncompressed. If this is not the behavior we want, I can change it.