fix: stub sdk-test-helpers in browser environments #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "sdk-test-helpers" file contains helper functions that generated SDKs use in their generated unit tests. These functions are never actually needed when running standard operational code, therefore they are never used in the browser. The `expect` library that we use for testing has a dependency that isn't browser friendly in certain scenarios. This causes the core and any SDKs importing it to throw errors in these scenarios (like the React framework). This change stubs the sdk-test-helpers in browser environments the same way we stub the credentials file reading code.
ibm-devx-automation
pushed a commit
that referenced
this pull request
Apr 1, 2021
## [2.10.3](v2.10.2...v2.10.3) (2021-04-01) ### Bug Fixes * stub sdk-test-helpers in browser environments ([#132](#132)) ([006991b](006991b))
|
🎉 This PR is included in version 2.10.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "sdk-test-helpers" file contains helper functions that generated SDKs use
in their generated unit tests. These functions are never actually needed when
running standard operational code, therefore they are never used in the browser.
The
expectlibrary that we use for testing has a dependency that isn't browserfriendly in certain scenarios. This causes the core and any SDKs importing it
to throw errors in these scenarios (like the React framework).
This change stubs the sdk-test-helpers in browser environments the same way we
stub the credentials file reading code. I've verified that this fix works in the problematic environments
cc @apaparazzi0329