Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update dependencies #161

Merged
merged 1 commit into from
Sep 9, 2021
Merged

chore: update dependencies #161

merged 1 commit into from
Sep 9, 2021

Conversation

barrett-schonefeld
Copy link
Contributor

@barrett-schonefeld barrett-schonefeld commented Sep 9, 2021 •
edited
Loading

Screen Shot 2021-09-09 at 12 35 08 PM

barrett-schonefeld
barrett-schonefeld commented Sep 9, 2021
View reviewed changes
package-lock.json
"version": "3.2.1",
"resolved": "https://registry.npmjs.org/conventional-commits-parser/-/conventional-commits-parser-3.2.1.tgz",
"integrity": "sha512-OG9kQtmMZBJD/32NEw5IhN5+HnBqVjy03eC+I71I0oQRFA5rOgA4OtPOYG7mz1GkCfCNxn3gKIX8EiHJYuf1cA==",
"version": "3.2.2",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@padamstx
Copy link
Member

padamstx commented Sep 9, 2021

Screen Shot 2021-09-09 at 12 35 08 PM

yes, but I've found that npm audit didn't pick up the original vulnerabilities so I'm not sure about its credibility :)

padamstx
padamstx approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you'll need to use a commit message that starts with something like fix(build): ... to trigger a new patch release of the node core library so that users can immediately get the fixed version.

Edit: actually after thinking about this a little more and reviewing your node template PR, I guess node SDKs would not actually need to pull in a new version of the node core to fix this issue since they have to go through the same steps, etc.

@barrett-schonefeld barrett-schonefeld merged commit 8a37ef0 into main Sep 9, 2021
@barrett-schonefeld barrett-schonefeld deleted the update-dependencies branch September 9, 2021 17:57
ibm-devx-sdk pushed a commit that referenced this pull request Sep 9, 2021
@semantic-release-bot
chore(release): 2.14.3 [skip ci]
0c19b2f 
## [2.14.3](v2.14.2...v2.14.3) (2021-09-09)

### Bug Fixes

* **build:** update dependencies ([#161](#161)) ([8a37ef0](8a37ef0))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 2.14.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

JurajNyiri pushed a commit to JurajNyiri/node-sdk-core that referenced this pull request Aug 22, 2024
@dependabot @bessbd
build(deps): bump @types/node from 14.14.25 to 14.14.28 (IBM#161)
9d6e25f 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.25 to 14.14.28.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Bessenyei Balázs Donát <bessbd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padamstx padamstx padamstx approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barrett-schonefeld @padamstx @ibm-devx-sdk