fix(ContainerAuthenticator): add sa-token as default CR token filename #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padamstx
force-pushed
the
add-default-filename
branch
from
6f9805d to
2151eb3
Compare
padamstx
force-pushed
the
add-default-filename
branch
from
2151eb3 to
7c440fc
Compare
padamstx
changed the title
padamstx
commented
May 3, 2023
| @@ -69,7 +69,9 @@ export class ContainerTokenManager extends IamRequestBasedTokenManager { | |||
| throw new Error('At least one of `iamProfileName` or `iamProfileId` must be specified.'); | |||
| } | |||
|
|
|||
| this.crTokenFilename = options.crTokenFilename || DEFAULT_CR_TOKEN_FILEPATH; | |||
| if (options.crTokenFilename) { | |||
There was a problem hiding this comment.
There's really no reason to store the default filename in "this" if the user didn't specify a filename, so made this change to be consistent with Go and Java.
dpopp07
approved these changes
May 19, 2023
This commit adds support for a second default CR token filename. If the user doesn't specify a CR token filename, the authenticator will first try '/var/run/secrets/tokens/vault-token', and then '/var/run/secrets/tokens/sa-token' in that order. Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
padamstx
force-pushed
the
add-default-filename
branch
from
7c440fc to
490db60
Compare
ibm-devx-sdk
pushed a commit
that referenced
this pull request
May 22, 2023
## [4.0.7](v4.0.6...v4.0.7) (2023-05-22) ### Bug Fixes * **ContainerAuthenticator:** add sa-token as default CR token filename ([#241](#241)) ([91f9932](91f9932))
|
🎉 This PR is included in version 4.0.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the ContainerAuthenticator so that it supports a second default CR token
filename.
Checklist
npm testpasses (tip:npm run lint-fixcan correct most style issues)