Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ref checker to skip external refs and flag issues as warnings #16

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

mkistler
Copy link
Contributor

This PR changes the validation of $refs to skip external refs, since these may have arbitrary structure.
Also, non-conforming refs are now reported as warnings rather than errors, since the OAS spec allows references into other parts of the API doc, but these should still be discouraged.

Fixes #13

@mkistler mkistler requested a review from dpopp07 January 25, 2019 17:17
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mkistler mkistler merged commit 6853a5e into master Jan 30, 2019
@mkistler mkistler deleted the mdk/fix-ref-checker branch February 3, 2019 14:48
@dpopp07
Copy link
Member

dpopp07 commented Feb 5, 2019

🎉 This PR is included in version 0.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants