scaffolded OperatorConfig API #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry H Li <henry.h.li@ibm.com>
Daniel-Fan
reviewed
Mar 20, 2024
main.go
Outdated
Comment on lines
170
to
176
| if err = (&controllers.OperatorConfigReconciler{ | ||
| Client: mgr.GetClient(), | ||
| Scheme: mgr.GetScheme(), | ||
| }).SetupWithManager(mgr); err != nil { | ||
| klog.Error(err, "unable to create controller", "controller", "OperatorConfig") | ||
| os.Exit(1) | ||
| } |
There was a problem hiding this comment.
Hi @bitscuit
May I ask that is there any concern if we follow the convention, to wrap the operatorConfig controller under interface ODLMOperator?
if err = (&operandconfig.Reconciler{
ODLMOperator: deploy.NewODLMOperator(mgr, "OperandConfig"),
}).SetupWithManager(mgr); err != nil {
klog.Errorf("unable to create controller OperandConfig: %v", err)
os.Exit(1)
}Signed-off-by: Henry H Li <henry.h.li@ibm.com>
Signed-off-by: Henry H Li <henry.h.li@ibm.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitscuit, Daniel-Fan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opening PR now for easier reviewing since a lot of files are generated when a new API is added.
How to test:
Should be no change to functionality, just able to install it and see OperatorConfig CRD