-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scaffolded OperatorConfig API #1027
Conversation
Signed-off-by: Henry H Li <henry.h.li@ibm.com>
main.go
Outdated
if err = (&controllers.OperatorConfigReconciler{ | ||
Client: mgr.GetClient(), | ||
Scheme: mgr.GetScheme(), | ||
}).SetupWithManager(mgr); err != nil { | ||
klog.Error(err, "unable to create controller", "controller", "OperatorConfig") | ||
os.Exit(1) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bitscuit
May I ask that is there any concern if we follow the convention, to wrap the operatorConfig
controller under interface ODLMOperator
?
if err = (&operandconfig.Reconciler{
ODLMOperator: deploy.NewODLMOperator(mgr, "OperandConfig"),
}).SetupWithManager(mgr); err != nil {
klog.Errorf("unable to create controller OperandConfig: %v", err)
os.Exit(1)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, done
Signed-off-by: Henry H Li <henry.h.li@ibm.com>
Signed-off-by: Henry H Li <henry.h.li@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitscuit, Daniel-Fan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
opening PR now for easier reviewing since a lot of files are generated when a new API is added.
How to test:
Should be no change to functionality, just able to install it and see OperatorConfig CRD