Skip catalog discover when operator is not found in OperandRegistry #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitscuit
reviewed
Jun 3, 2024
controllers/operator/manager.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| if opt != nil { |
There was a problem hiding this comment.
suggest to invert the condition, so that if opt is nil, then return nil. Will be easier to read the code, and best practice is to return as early as possible.
Signed-off-by: Daniel Fan <fanyuchensx@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bitscuit, Daniel-Fan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When operator is not found in OperandRegistry,
optisniland there should be no catalog discovery for thisnilobject.Which issue(s) this PR fixes:
Fixes https://github.ibm.com/IBMPrivateCloud/roadmap/issues/63690#issuecomment-81218953
Test
See comment https://github.ibm.com/IBMPrivateCloud/roadmap/issues/63690#issuecomment-81222501