Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OperandBindinfo example into alm-example #968

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

Daniel-Fan
Copy link
Contributor

Fix validation error from operator-sdk

WARN[0000] Warning: Value operator.ibm.com/v1alpha1, Kind=OperandBindInfo: provided API should have an example annotation 

for validation

Signed-off-by: Daniel Fan <fanyuchensx@gmail.com>
@Daniel-Fan
Copy link
Contributor Author

/retest

Signed-off-by: Daniel Fan <fanyuchensx@gmail.com>
Copy link
Member

@bitscuit bitscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitscuit, Daniel-Fan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Daniel-Fan,bitscuit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot added the lgtm label Sep 7, 2023
@Daniel-Fan
Copy link
Contributor Author

/retest

@ibm-ci-bot ibm-ci-bot merged commit e9760db into IBM:master Sep 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants