Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IAM Policy Management): update subject attribute value #297

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

swcolley
Copy link
Contributor

Issue: https://github.ibm.com/IAM/AM-issues/issues/2140

PR summary

Minor fix of subject attribute value type to match API and other attributes value type.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Subject attribute value should not be limited to a string, but should allow for other types based on API. This change allows that.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Out of testing:
Integration tests:

shaunsmacibm@Shauns-MacBook-Pro iampolicymanagementv1 % go test -tags=integration
Running Suite: IamPolicyManagementV1 Suite
==========================================
Random Seed: 1705526859
Will run 212 of 212 specs

••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••••
Ran 212 of 212 Specs in 19.390 seconds
SUCCESS! -- 212 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

examples:

Ran 214 of 214 Specs in 28.957 seconds
SUCCESS! -- 214 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestIamPolicyManagementV1 (29.02s)
PASS

…PI def

Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 21accf1 into main Jan 26, 2024
4 checks passed
@padamstx padamstx deleted the v2PolicySubjectValueFix branch January 26, 2024 21:46
ibm-devx-sdk pushed a commit that referenced this pull request Jan 26, 2024
## [0.56.3](v0.56.2...v0.56.3) (2024-01-26)

### Bug Fixes

* **IAM Policy Management:** update subject attribute value based on API def ([#297](#297)) ([21accf1](21accf1))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.56.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants