-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Configuration Governance): add service to project #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just found 1 minor typo
if err != nil { | ||
Skip("Error loading service properties, skipping tests: " + err.Error()) | ||
Skip("Error loading service properties, skipping te0sts: " + err.Error()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo
Skip("Error loading service properties, skipping te0sts: " + err.Error()) | |
Skip("Error loading service properties, skipping tests: " + err.Error()) |
# [0.11.0](v0.10.0...v0.11.0) (2020-08-31) ### Features * **Configuration Governance:** add service to project ([#42](#42)) ([fe0fc93](fe0fc93))
🎉 This PR is included in version 0.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
This PR adds the Configuration Governance service to the project.
PR Checklist
Please make sure that your PR fulfills the following requirements:
PR Type
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change?
Other information