Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Configuration Governance): add service to project #42

Merged
merged 8 commits into from
Aug 31, 2020
Merged

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Aug 27, 2020

PR summary

This PR adds the Configuration Governance service to the project.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx self-assigned this Aug 27, 2020
@padamstx padamstx requested a review from jorge-ibm August 29, 2020 11:22
Copy link
Contributor

@jorge-ibm jorge-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just found 1 minor typo

if err != nil {
Skip("Error loading service properties, skipping tests: " + err.Error())
Skip("Error loading service properties, skipping te0sts: " + err.Error())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo

Suggested change
Skip("Error loading service properties, skipping te0sts: " + err.Error())
Skip("Error loading service properties, skipping tests: " + err.Error())

@padamstx padamstx merged commit fe0fc93 into master Aug 31, 2020
@padamstx padamstx deleted the add-config branch August 31, 2020 21:52
ibm-devx-automation pushed a commit that referenced this pull request Aug 31, 2020
# [0.11.0](v0.10.0...v0.11.0) (2020-08-31)

### Features

* **Configuration Governance:** add service to project ([#42](#42)) ([fe0fc93](fe0fc93))
@ibm-devx-automation
Copy link

🎉 This PR is included in version 0.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants