Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add Go 1.19 #204

Merged
merged 1 commit into from
Sep 2, 2022
Merged

build: add Go 1.19 #204

merged 1 commit into from
Sep 2, 2022

Conversation

pyrooka
Copy link
Member

@pyrooka pyrooka commented Sep 2, 2022

PR summary

This commit enables building the project on Go 1.19.
It also updates the golangci-lint package version
to resolve a compatibility issue with the latest Go version.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Signed-off-by: Norbert Biczo pyrooka@users.noreply.github.com

Signed-off-by: Norbert Biczo <pyrooka@users.noreply.github.com>
@pyrooka pyrooka self-assigned this Sep 2, 2022
@pyrooka pyrooka requested a review from padamstx September 2, 2022 15:32
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pyrooka pyrooka merged commit 5d0b22e into main Sep 2, 2022
@pyrooka pyrooka deleted the add-go-119 branch September 2, 2022 17:13
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.28.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants