Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (User Management): add query params search and include_settings to list_users operation #246

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

PureMathematics
Copy link
Contributor

@PureMathematics PureMathematics commented Apr 21, 2023

PR summary

Update Include_settings and substring search functionality (User Management)

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

the current issue for updating SDK https://github.ibm.com/IAM/uum/issues/5882
the previous issue for the user management code change https://github.ibm.com/IAM/uum/issues/4948

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


David-Lim0305 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@PureMathematics PureMathematics changed the title featupdate user management sdk with list user api update feat (user management) update user management sdk with list user api update Apr 21, 2023
PureMathematics pushed a commit that referenced this pull request Apr 21, 2023
…PI (#246)

    Signed-off-by: David Lim <David.Lim0305@ibm.com>
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from ec87449 to 991ac2f Compare April 21, 2023 19:53
PureMathematics pushed a commit that referenced this pull request Apr 21, 2023
…PI (#246)

    Signed-off-by: David Lim <david.dongsuk.lim@gmail.com>
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 991ac2f to b206241 Compare April 21, 2023 19:56
PureMathematics pushed a commit that referenced this pull request Apr 21, 2023
…PI (#246)

    Signed-off-by: David Lim <david.dongsuk.lim@gmail.com>
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from b206241 to 9660489 Compare April 21, 2023 19:58
PureMathematics pushed a commit that referenced this pull request Apr 21, 2023
…PI (#246)

    Signed-off-by: David Lim <dlim46@gatech.edu>
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 9660489 to 0aa90fa Compare April 21, 2023 20:01
@padamstx padamstx self-requested a review April 24, 2023 15:37
@padamstx padamstx self-assigned this Apr 24, 2023
PureMathematics pushed a commit that referenced this pull request Apr 24, 2023
…PI (#246)

    Signed-off-by: David Lim <David.Lim0305@ibm.com>
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 0aa90fa to 2c7e16d Compare April 24, 2023 19:49
PureMathematics pushed a commit that referenced this pull request Apr 24, 2023
…PI (#246)

    Signed-off-by: David Lim <David.Lim0305@ibm.com>
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 2c7e16d to 7ae8f99 Compare April 24, 2023 21:02
PureMathematics pushed a commit that referenced this pull request Apr 24, 2023
…PI (#246)

    Signed-off-by: David Lim <David.Lim0305@ibm.com>
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 7ae8f99 to 93676e8 Compare April 24, 2023 21:09
PureMathematics pushed a commit that referenced this pull request Apr 24, 2023
…PI (#246)

    Signed-off-by: David Lim <David.Lim0305@ibm.com>
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 93676e8 to d838ca7 Compare April 24, 2023 21:15
PureMathematics pushed a commit that referenced this pull request Apr 25, 2023
…PI (#246)

    Signed-off-by: David Lim <David.Lim0305@ibm.com>
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from d838ca7 to a57e092 Compare April 25, 2023 16:25
PureMathematics pushed a commit that referenced this pull request Apr 25, 2023
…PI (#246)

    Signed-off-by: David Lim <David.Lim0305@ibm.com>
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from a57e092 to 36d1041 Compare April 25, 2023 16:54
PureMathematics pushed a commit that referenced this pull request Apr 25, 2023
…PI (#246)

    Signed-off-by: David Lim <David.Lim0305@ibm.com>
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 36d1041 to e04ce1b Compare April 25, 2023 18:31
PureMathematics pushed a commit that referenced this pull request Apr 25, 2023
…PI (#246)

    Signed-off-by: David Lim <David.Lim0305@ibm.com>
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from e04ce1b to b4a4af8 Compare April 25, 2023 18:36
PureMathematics pushed a commit that referenced this pull request Apr 25, 2023
…PI (#246)

    Signed-off-by: David Lim <David.Lim0305@ibm.com>
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from b4a4af8 to 8a9b4c6 Compare April 25, 2023 18:51
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 1a68589 to f5f10a6 Compare April 25, 2023 19:45
PureMathematics pushed a commit that referenced this pull request Apr 25, 2023
… for GET list users API (#246)

    Signed-off-by: David Lim <David.Lim0305@ibm.com>
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch 2 times, most recently from 3a3799b to 76a6c35 Compare April 25, 2023 20:50
PureMathematics pushed a commit that referenced this pull request Apr 25, 2023
… for GET list users API (#246)

    Signed-off-by: David Lim <David.Lim0305@ibm.com>
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 76a6c35 to fbf4d71 Compare April 25, 2023 20:51
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the PR looks good, except for the multiple example code fragments for the list_users operation.
Also, you are getting the failure in the DCO check because you did not sign-off your commit. Next time you amend your commit, be sure to use the -s option.

usermanagementv1/user_management_v1_examples_test.go Outdated Show resolved Hide resolved
PureMathematics pushed a commit that referenced this pull request Apr 27, 2023
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from fbf4d71 to 53be9da Compare April 27, 2023 21:18
PureMathematics pushed a commit that referenced this pull request Apr 27, 2023
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 53be9da to d81567c Compare April 27, 2023 21:27
PureMathematics pushed a commit that referenced this pull request Apr 27, 2023
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from d81567c to 3e28912 Compare April 27, 2023 21:31
PureMathematics pushed a commit that referenced this pull request Apr 27, 2023
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 3e28912 to e5db872 Compare April 27, 2023 21:34
PureMathematics pushed a commit that referenced this pull request Apr 27, 2023
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from e5db872 to 046c777 Compare April 27, 2023 21:57
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx changed the title feat (user management) update user management sdk with list user api update feat (User Management): add query params search and include_settings to list_users operation Apr 28, 2023
PureMathematics pushed a commit that referenced this pull request Apr 28, 2023
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 046c777 to 6440058 Compare April 28, 2023 14:48
@PureMathematics PureMathematics force-pushed the update-uum-listusers-api-sdk branch from 6440058 to 09485ee Compare April 28, 2023 15:32
@PureMathematics
Copy link
Contributor Author

examples test
Go-examples

@PureMathematics
Copy link
Contributor Author

Integration test
Go-integration

Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

usermanagementv1/user_management_v1_examples_test.go Outdated Show resolved Hide resolved
@padamstx padamstx merged commit 9393079 into main Apr 28, 2023
@padamstx padamstx deleted the update-uum-listusers-api-sdk branch April 28, 2023 22:59
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.37.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants