-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (User Management): add query params search and include_settings to list_users operation #246
Conversation
David-Lim0305 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
…PI (#246) Signed-off-by: David Lim <David.Lim0305@ibm.com>
ec87449
to
991ac2f
Compare
…PI (#246) Signed-off-by: David Lim <david.dongsuk.lim@gmail.com>
991ac2f
to
b206241
Compare
…PI (#246) Signed-off-by: David Lim <david.dongsuk.lim@gmail.com>
b206241
to
9660489
Compare
…PI (#246) Signed-off-by: David Lim <dlim46@gatech.edu>
9660489
to
0aa90fa
Compare
…PI (#246) Signed-off-by: David Lim <David.Lim0305@ibm.com>
0aa90fa
to
2c7e16d
Compare
…PI (#246) Signed-off-by: David Lim <David.Lim0305@ibm.com>
2c7e16d
to
7ae8f99
Compare
…PI (#246) Signed-off-by: David Lim <David.Lim0305@ibm.com>
7ae8f99
to
93676e8
Compare
…PI (#246) Signed-off-by: David Lim <David.Lim0305@ibm.com>
93676e8
to
d838ca7
Compare
…PI (#246) Signed-off-by: David Lim <David.Lim0305@ibm.com>
d838ca7
to
a57e092
Compare
…PI (#246) Signed-off-by: David Lim <David.Lim0305@ibm.com>
a57e092
to
36d1041
Compare
…PI (#246) Signed-off-by: David Lim <David.Lim0305@ibm.com>
36d1041
to
e04ce1b
Compare
…PI (#246) Signed-off-by: David Lim <David.Lim0305@ibm.com>
e04ce1b
to
b4a4af8
Compare
…PI (#246) Signed-off-by: David Lim <David.Lim0305@ibm.com>
b4a4af8
to
8a9b4c6
Compare
1a68589
to
f5f10a6
Compare
… for GET list users API (#246) Signed-off-by: David Lim <David.Lim0305@ibm.com>
3a3799b
to
76a6c35
Compare
… for GET list users API (#246) Signed-off-by: David Lim <David.Lim0305@ibm.com>
76a6c35
to
fbf4d71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the PR looks good, except for the multiple example code fragments for the list_users operation.
Also, you are getting the failure in the DCO check because you did not sign-off your commit. Next time you amend your commit, be sure to use the -s
option.
… for GET list users API (#246)
fbf4d71
to
53be9da
Compare
… for GET list users API (#246)
53be9da
to
d81567c
Compare
… for GET list users API (#246)
d81567c
to
3e28912
Compare
… for GET list users API (#246)
3e28912
to
e5db872
Compare
… for GET list users API (#246)
e5db872
to
046c777
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… for GET list users API (#246)
046c777
to
6440058
Compare
… for GET list users API (#246)
6440058
to
09485ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 0.37.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
Update Include_settings and substring search functionality (User Management)
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information
the current issue for updating SDK https://github.ibm.com/IAM/uum/issues/5882
the previous issue for the user management code change https://github.ibm.com/IAM/uum/issues/4948