Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IAM Identity): adding effective account settings #347

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

pooraniss-ibm
Copy link
Member

@pooraniss-ibm pooraniss-ibm commented Aug 1, 2024

PR summary

new endpoint to get Effective account settings,
also has action control added to existing template calls.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other informatio

Screenshot 2024-08-01 at 09 40 02 n Screenshot 2024-07-31 at 19 54 31

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2024

CLA assistant check
All committers have signed the CLA.

@pooraniss-ibm
Copy link
Member Author

added screenshots of passing test cases :)

@padamstx
Copy link
Member

padamstx commented Aug 2, 2024

@pooraniss-ibm Could you please sign off on your commit? That is the "DCO" failure in the list of checks for the PR. To sign off on your commit, you could use the "-s" option on git commit. More details here: https://github.com/IBM/platform-services-go-sdk/blob/main/update_service.md#7-open-pr-with-your-changes

@padamstx padamstx self-assigned this Aug 2, 2024
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to regen with the latest generator and production API defn.

iamidentityv1/iam_identity_v1.go Outdated Show resolved Hide resolved
@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-effectiveAccSettings branch from 5e77e6d to 44ae16b Compare August 6, 2024 10:53
pooraniss-ibm and others added 3 commits August 6, 2024 12:47
Signed-off-by: poorani <poorani.senthilkumar.sankari@ibm.com>
This commit removes the use of the gosec standalone tool
and enables the gosec linter supported by golangci-lint.

Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
Signed-off-by: poorani <poorani.senthilkumar.sankari@ibm.com>
Signed-off-by: poorani <poorani.senthilkumar.sankari@ibm.com>
@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-effectiveAccSettings branch from 2493415 to b312cfa Compare August 6, 2024 11:48
@pooraniss-ibm pooraniss-ibm requested a review from padamstx August 12, 2024 02:01
@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-effectiveAccSettings branch from 28b363c to b9f6466 Compare August 12, 2024 20:38
@pooraniss-ibm pooraniss-ibm force-pushed the iam-identity-effectiveAccSettings branch from b9f6466 to 737855c Compare August 12, 2024 21:05
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iamidentityv1/iam_identity_v1.go Outdated Show resolved Hide resolved
@padamstx padamstx merged commit bd383f8 into main Aug 12, 2024
4 checks passed
@padamstx padamstx deleted the iam-identity-effectiveAccSettings branch August 12, 2024 21:33
ibm-devx-sdk pushed a commit that referenced this pull request Aug 12, 2024
# [0.66.0](v0.65.1...v0.66.0) (2024-08-12)

### Features

* **IAM Identity:** adding effective account settings ([#347](#347)) ([bd383f8](bd383f8))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.66.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants