-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(IAM Identity): adding effective account settings #347
Conversation
added screenshots of passing test cases :) |
@pooraniss-ibm Could you please sign off on your commit? That is the "DCO" failure in the list of checks for the PR. To sign off on your commit, you could use the "-s" option on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to regen with the latest generator and production API defn.
5e77e6d
to
44ae16b
Compare
Signed-off-by: poorani <poorani.senthilkumar.sankari@ibm.com>
This commit removes the use of the gosec standalone tool and enables the gosec linter supported by golangci-lint. Signed-off-by: Phil Adams <phil_adams@us.ibm.com> Signed-off-by: poorani <poorani.senthilkumar.sankari@ibm.com>
Signed-off-by: poorani <poorani.senthilkumar.sankari@ibm.com>
2493415
to
b312cfa
Compare
28b363c
to
b9f6466
Compare
b9f6466
to
737855c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# [0.66.0](v0.65.1...v0.66.0) (2024-08-12) ### Features * **IAM Identity:** adding effective account settings ([#347](#347)) ([bd383f8](bd383f8))
🎉 This PR is included in version 0.66.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
new endpoint to get Effective account settings,
also has action control added to existing template calls.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other informatio
n