Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move ibm-platform-services package to @ibm-cloud npm org #118

Merged
merged 3 commits into from
Jul 21, 2021

Conversation

Andras-Csanyi
Copy link
Contributor

@Andras-Csanyi Andras-Csanyi commented Jul 19, 2021

PR summary

Changes in this PR are going to

  • change ibm-platform-services package name to platform-services, and
  • move it to @ibm-cloud organisation
  • update README according to the above changes

From this point forward the package is @ibm-cloud/platform-services.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #118 (a02e2fa) into main (dcce91f) will not change coverage.
The diff coverage is n/a.

❗ Current head a02e2fa differs from pull request most recent head 9dea7df. Consider uploading reports for the commit 9dea7df to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #118   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines         3302      3302           
  Branches       402       402           
=========================================
  Hits          3302      3302           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5cd7e3...9dea7df. Read the comment docs.

@Andras-Csanyi Andras-Csanyi changed the title fix: move platform-services package to @ibm-cloud npm org fix: move ibm-platform-services package to @ibm-cloud npm org Jul 19, 2021
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Within the README (list of services) I think we need to include @ibm-cloud/in the import path. Pretty sure an app would need to use something like this to import the package:

   const CaseManagementV1 = require(`@ibm-cloud/platform-services/case-management/v1`);

@Andras-Csanyi Andras-Csanyi requested a review from padamstx July 19, 2021 15:27
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@Andras-Csanyi Andras-Csanyi merged commit 751dc4d into main Jul 21, 2021
ibm-devx-sdk pushed a commit that referenced this pull request Jul 21, 2021
## [0.19.1](v0.19.0...v0.19.1) (2021-07-21)

### Bug Fixes

* move ibm-platform-services package to [@IBM-Cloud](https://github.com/ibm-cloud) npm org ([#118](#118)) ([751dc4d](751dc4d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants