-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move ibm-platform-services package to @ibm-cloud npm org #118
Conversation
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 3302 3302
Branches 402 402
=========================================
Hits 3302 3302 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Within the README (list of services) I think we need to include @ibm-cloud/
in the import path. Pretty sure an app would need to use something like this to import the package:
const CaseManagementV1 = require(`@ibm-cloud/platform-services/case-management/v1`);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
## [0.19.1](v0.19.0...v0.19.1) (2021-07-21) ### Bug Fixes * move ibm-platform-services package to [@IBM-Cloud](https://github.com/ibm-cloud) npm org ([#118](#118)) ([751dc4d](751dc4d))
PR summary
Changes in this PR are going to
ibm-platform-services
package name toplatform-services
, and@ibm-cloud
organisationFrom this point forward the package is
@ibm-cloud/platform-services
.PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information