Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update core major version #189

Merged
merged 4 commits into from
Dec 20, 2022
Merged

fix: update core major version #189

merged 4 commits into from
Dec 20, 2022

Conversation

dpopp07
Copy link
Member

@dpopp07 dpopp07 commented Dec 20, 2022

This updates the Node core to v4, which includes axios 1.0 as a
dependency. Since a number of potential issues have been solved by
v1, I'm treating this as a fix so a new release gets published
including the new core version.

@dpopp07 dpopp07 requested a review from padamstx December 20, 2022 17:51
@CLAassistant
Copy link

CLAassistant commented Dec 20, 2022

CLA assistant check
All committers have signed the CLA.

@dpopp07 dpopp07 changed the title Dp/update core major version fix: update core major version Dec 20, 2022
@dpopp07 dpopp07 force-pushed the dp/update-core-major-version branch from 514a4e4 to 217ef82 Compare December 20, 2022 17:55
dpopp07 and others added 4 commits December 20, 2022 11:57
Signed-off-by: Dustin Popp <dpopp07@gmail.com>
Signed-off-by: Dustin Popp <dpopp07@gmail.com>
This updates the Node core to v4, which includes `axios` 1.0 as a
dependency. Since a number of potential issues have been solved by
v1, I'm treating this as a fix so a new release gets published
including the new core version.

Signed-off-by: Dustin Popp <dpopp07@gmail.com>
Signed-off-by: Dustin Popp <dpopp07@gmail.com>
@dpopp07 dpopp07 force-pushed the dp/update-core-major-version branch from 217ef82 to 48e58c0 Compare December 20, 2022 17:58
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dpopp07 dpopp07 merged commit cc6fefc into main Dec 20, 2022
@dpopp07 dpopp07 deleted the dp/update-core-major-version branch December 20, 2022 18:34
ibm-devx-sdk pushed a commit that referenced this pull request Dec 20, 2022
## [0.30.1](v0.30.0...v0.30.1) (2022-12-20)

### Bug Fixes

* update core to new major version ([#189](#189)) ([cc6fefc](cc6fefc))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.30.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants