Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Resource Controller): add "onetime_credentials" property in ResourceInstance and ResourceKey schemas #263

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

swadhin1515
Copy link
Contributor

@swadhin1515 swadhin1515 commented Jul 10, 2024

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

…ceInstance and ResourceKey schemas

Signed-off-by: swadhin1515 <swadhinrc1518@gmail.com>
Signed-off-by: swadhin1515 <swadhinrc1518@gmail.com>
@swadhin1515 swadhin1515 force-pushed the onetime_credentials_update branch from 1759e1f to b9f1336 Compare July 10, 2024 12:58
…ceInstance and ResourceKey schemas

Signed-off-by: swadhin1515 <swadhinrc1518@gmail.com>
…ceInstance and ResourceKey schemas

Signed-off-by: swadhin1515 <swadhinrc1518@gmail.com>
@swadhin1515
Copy link
Contributor Author

@padamstx padamstx requested a review from pyrooka July 10, 2024 16:43
@pyrooka pyrooka changed the title feat(Resource Controller): add onetime_credentials property in Resour… feat(Resource Controller): add "onetime_credentials" property in ResourceInstance and ResourceKey schemas Jul 10, 2024
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good here!

@pyrooka pyrooka merged commit e3bc46c into IBM:main Jul 11, 2024
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Jul 11, 2024
# [0.55.0](v0.54.2...v0.55.0) (2024-07-11)

### Features

* **Resource Controller:** add "onetime_credentials" property in ResourceInstance and ResourceKey schemas ([#263](#263)) ([e3bc46c](e3bc46c))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.55.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants