Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Resource Controller): add "onetime_credentials" property in ResourceInstance and ResourceKey schemas #261

Closed
wants to merge 1 commit into from

Conversation

swadhin1515
Copy link
Contributor

…nce and ResourceKey schema

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@swadhin1515 swadhin1515 force-pushed the onetime_credentials branch 2 times, most recently from c4c1b7b to 47b2a3a Compare July 1, 2024 05:33
@pyrooka pyrooka changed the title feat(Resource Controller): Added onetime_credentials to ResourceInsta… feat(Resource Controller): add "onetime_credentials" property in ResourceInstance and ResourceKey schemas Jul 5, 2024
@pyrooka pyrooka self-requested a review July 5, 2024 06:59
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems something has been messed up in your git history, because there is a change in the CHANGELOG.md that shouldn't be here and the change in the service (resource_controller_v2.py) is unusually big. Please make sure that your git history is clean and only include the necessary changes.

If everything okay, please attach the result of the integration and examples test run. You can find more details about how to run them in THIS documentation, but you can also check previous PRs to see the "format" there.

@swadhin1515
Copy link
Contributor Author

* **Global Tagging:** add 'update' option to attach_tag operation ([IBM#259](IBM#259)) ([47324d5](IBM@47324d5))

Signed-off-by: swadhin1515 <swadhinrc1518@gmail.com>
@swadhin1515 swadhin1515 force-pushed the onetime_credentials branch from 47b2a3a to ad03103 Compare July 10, 2024 10:13
@pyrooka
Copy link
Member

pyrooka commented Jul 10, 2024

@swadhin1515 Can we close this PR in favor of #263?

@swadhin1515
Copy link
Contributor Author

Yes sure , we can close this PR .

@pyrooka pyrooka closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants