Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IAM Policy Management): add support for v2/policies #184

Merged
merged 4 commits into from
Jan 25, 2023
Merged

Conversation

swcolley
Copy link
Contributor

@swcolley swcolley commented Dec 7, 2022

PR summary

Code to support new v2/policies API has been introduced. The new v2/policies API will have new JSON fields and existing v1/fields have been changed.

v1/policies API will continue to be supported.

PR Checklist

Please make sure that your PR fulfills the following requirements:

Current vs new behavior

Current behavior will remain same (v1 will continue to be supported). New behavior is v2/policies support which allows for time based restriction policies using new rule field (an integration test has been added of this example).

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

See:
Issue: https://github.ibm.com/IAM/AM-issues/issues/925
TRI: https://github.ibm.com/IAM/architecture/blob/master/TRIDocs/Access-Management/Smart-Policies/smart_policies.md

Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
@padamstx padamstx self-requested a review December 12, 2022 16:27
@padamstx padamstx self-assigned this Dec 12, 2022
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

padamstx and others added 3 commits January 24, 2023 18:21
…attern, update property names based on API definition changes, and add support for tags

Signed-off-by: Shaun Colley <shaun.colley@ibm.com>
@padamstx padamstx merged commit d0af471 into main Jan 25, 2023
@padamstx padamstx deleted the v2-policies branch January 25, 2023 20:47
ibm-devx-sdk pushed a commit that referenced this pull request Jan 25, 2023
# [0.31.0](v0.30.3...v0.31.0) (2023-01-25)

### Features

* **IAM Policy Management:** add support for v2/policies ([#184](#184)) ([d0af471](d0af471))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.31.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants