-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enable builds on Windows #215
Conversation
76c01fe
to
663b74f
Compare
Updated this PR to completely remove the pylint.sh and .bat files. Instead, I updated the Makefile so that the "lint" and "lint-fix" targets invoke pylint directly instead of via the scripts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
## [0.40.1](v0.40.0...v0.40.1) (2023-08-31) ### Bug Fixes * enable builds on Windows ([#215](#215)) ([6395ae1](6395ae1))
🎉 This PR is included in version 0.40.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
PR summary
This PR modifies the project to allow developers to build and test the project on Windows.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Does this PR introduce a breaking change?
Other information