Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable builds on Windows #215

Merged
merged 1 commit into from
Aug 31, 2023
Merged

fix: enable builds on Windows #215

merged 1 commit into from
Aug 31, 2023

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Aug 25, 2023

PR summary

This PR modifies the project to allow developers to build and test the project on Windows.

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@padamstx padamstx self-assigned this Aug 25, 2023
@padamstx padamstx force-pushed the fix-windows branch 2 times, most recently from 76c01fe to 663b74f Compare August 25, 2023 17:39
@padamstx padamstx changed the title fix: enable builds on Windows [skip ci] fix: enable builds on Windows Aug 25, 2023
@padamstx padamstx marked this pull request as ready for review August 25, 2023 17:40
@padamstx
Copy link
Member Author

Updated this PR to completely remove the pylint.sh and .bat files. Instead, I updated the Makefile so that the "lint" and "lint-fix" targets invoke pylint directly instead of via the scripts.

Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

update_service.md Show resolved Hide resolved
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
@padamstx padamstx merged commit 6395ae1 into main Aug 31, 2023
@padamstx padamstx deleted the fix-windows branch August 31, 2023 19:36
ibm-devx-sdk pushed a commit that referenced this pull request Aug 31, 2023
## [0.40.1](v0.40.0...v0.40.1) (2023-08-31)

### Bug Fixes

* enable builds on Windows ([#215](#215)) ([6395ae1](6395ae1))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.40.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants