Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IAM Access Groups): Remove update action control from assertions #218

Merged
merged 1 commit into from
Sep 5, 2023
Merged

fix(IAM Access Groups): Remove update action control from assertions #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions examples/test_iam_access_groups_v2_examples.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,6 @@ def test_create_template_example(self):

rules_action_controls_model = {
'remove': False,
'update': False,
}

rule_input_model = {
Expand All @@ -562,7 +561,6 @@ def test_create_template_example(self):
assertions_action_controls_model = {
'add': False,
'remove': True,
'update': True,
}

assertions_input_model = {
Expand Down Expand Up @@ -793,7 +791,6 @@ def test_update_template_version_example(self):

rules_action_controls_model = {
'remove': False,
'update': False,
}

rule_input_model = {
Expand Down
76 changes: 47 additions & 29 deletions ibm_platform_services/iam_access_groups_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# IBM OpenAPI SDK Code Generator Version: 3.74.0-89f1dbab-20230630-160213
# IBM OpenAPI SDK Code Generator Version: 3.78.0-67aec9b7-20230818-174940

"""
The IAM Access Groups API allows for the management of access groups (Create, Read,
Expand Down Expand Up @@ -2474,7 +2474,11 @@ class AccessActionControls:
:attr bool add: (optional) Action control for adding access policies to an
enterprise-managed access group in a child account. If an access group
administrator in a child account adds a policy, they can always update or remove
it.
it. Note that if conflicts arise between an update to this control in a new
version and polices added to the access group by an administrator in a child
account, you must resolve those conflicts in the child account. This prevents
breaking access in the child account. For more information, see [Working with
versions](https://test.cloud.ibm.com/docs/secure-enterprise?topic=secure-enterprise-working-with-versions#new-version-scenarios).
"""

def __init__(
Expand All @@ -2488,7 +2492,12 @@ def __init__(
:param bool add: (optional) Action control for adding access policies to an
enterprise-managed access group in a child account. If an access group
administrator in a child account adds a policy, they can always update or
remove it.
remove it. Note that if conflicts arise between an update to this control
in a new version and polices added to the access group by an administrator
in a child account, you must resolve those conflicts in the child account.
This prevents breaking access in the child account. For more information,
see [Working with
versions](https://test.cloud.ibm.com/docs/secure-enterprise?topic=secure-enterprise-working-with-versions#new-version-scenarios).
"""
self.add = add

Expand Down Expand Up @@ -3375,34 +3384,42 @@ class AssertionsActionControls:

:attr bool add: (optional) Action control for adding dynamic rules to an
enterprise-managed access group. If an access group administrator in a child
account adds a dynamic rule, they can always update or remove it.
account adds a dynamic rule, they can always update or remove it. Note that if
conflicts arise between an update to this control and rules added or updated by
an administrator in the child account, you must resolve those conflicts in the
child account. This prevents breaking access that the rules might grant in the
child account. For more information, see [Working with versions].
:attr bool remove: (optional) Action control for removing enterprise-managed
dynamic rules in an enterprise-managed access group.
:attr bool update: (optional) Action control for updating enterprise-managed
dynamic rules in an enterprise-managed access group.
dynamic rules in an enterprise-managed access group. Note that if a rule is
removed from an enterprise-managed access group by an administrator in a child
account and and you reassign the template, the rule is reinstated.
"""

def __init__(
self,
*,
add: bool = None,
remove: bool = None,
update: bool = None,
) -> None:
"""
Initialize a AssertionsActionControls object.

:param bool add: (optional) Action control for adding dynamic rules to an
enterprise-managed access group. If an access group administrator in a
child account adds a dynamic rule, they can always update or remove it.
Note that if conflicts arise between an update to this control and rules
added or updated by an administrator in the child account, you must resolve
those conflicts in the child account. This prevents breaking access that
the rules might grant in the child account. For more information, see
[Working with versions].
:param bool remove: (optional) Action control for removing
enterprise-managed dynamic rules in an enterprise-managed access group.
:param bool update: (optional) Action control for updating
enterprise-managed dynamic rules in an enterprise-managed access group.
Note that if a rule is removed from an enterprise-managed access group by
an administrator in a child account and and you reassign the template, the
rule is reinstated.
"""
self.add = add
self.remove = remove
self.update = update

@classmethod
def from_dict(cls, _dict: Dict) -> 'AssertionsActionControls':
Expand All @@ -3412,8 +3429,6 @@ def from_dict(cls, _dict: Dict) -> 'AssertionsActionControls':
args['add'] = _dict.get('add')
if 'remove' in _dict:
args['remove'] = _dict.get('remove')
if 'update' in _dict:
args['update'] = _dict.get('update')
return cls(**args)

@classmethod
Expand All @@ -3428,8 +3443,6 @@ def to_dict(self) -> Dict:
_dict['add'] = self.add
if hasattr(self, 'remove') and self.remove is not None:
_dict['remove'] = self.remove
if hasattr(self, 'update') and self.update is not None:
_dict['update'] = self.update
return _dict

def _to_dict(self):
Expand Down Expand Up @@ -5825,9 +5838,16 @@ class MembersActionControls:

:attr bool add: (optional) Action control for adding child account members to an
enterprise-managed access group. If an access group administrator in a child
account adds a member, they can always remove them.
account adds a member, they can always remove them. Note that if conflicts arise
between an update to this control in a new version and members added by an
administrator in the child account, you must resolve those conflicts in the
child account. This prevents breaking access in the child account. For more
information, see [Working with versions]
(https://test.cloud.ibm.com/docs/secure-enterprise?topic=secure-enterprise-working-with-versions#new-version-scenarios).
:attr bool remove: (optional) Action control for removing enterprise-managed
members from an enterprise-managed access group.
members from an enterprise-managed access group. Note that if an enterprise
member is removed from an enterprise-managed access group in a child account and
you reassign the template, the membership is reinstated.
"""

def __init__(
Expand All @@ -5841,9 +5861,17 @@ def __init__(

:param bool add: (optional) Action control for adding child account members
to an enterprise-managed access group. If an access group administrator in
a child account adds a member, they can always remove them.
a child account adds a member, they can always remove them. Note that if
conflicts arise between an update to this control in a new version and
members added by an administrator in the child account, you must resolve
those conflicts in the child account. This prevents breaking access in the
child account. For more information, see [Working with versions]
(https://test.cloud.ibm.com/docs/secure-enterprise?topic=secure-enterprise-working-with-versions#new-version-scenarios).
:param bool remove: (optional) Action control for removing
enterprise-managed members from an enterprise-managed access group.
enterprise-managed members from an enterprise-managed access group. Note
that if an enterprise member is removed from an enterprise-managed access
group in a child account and you reassign the template, the membership is
reinstated.
"""
self.add = add
self.remove = remove
Expand Down Expand Up @@ -6216,35 +6244,27 @@ class RuleActionControls:

:attr bool remove: (optional) Action control for removing this
enterprise-managed dynamic rule.
:attr bool update: (optional) Action control for updating this
enterprise-managed dynamic rule.
"""

def __init__(
self,
*,
remove: bool = None,
update: bool = None,
) -> None:
"""
Initialize a RuleActionControls object.

:param bool remove: (optional) Action control for removing this
enterprise-managed dynamic rule.
:param bool update: (optional) Action control for updating this
enterprise-managed dynamic rule.
"""
self.remove = remove
self.update = update

@classmethod
def from_dict(cls, _dict: Dict) -> 'RuleActionControls':
"""Initialize a RuleActionControls object from a json dictionary."""
args = {}
if 'remove' in _dict:
args['remove'] = _dict.get('remove')
if 'update' in _dict:
args['update'] = _dict.get('update')
return cls(**args)

@classmethod
Expand All @@ -6257,8 +6277,6 @@ def to_dict(self) -> Dict:
_dict = {}
if hasattr(self, 'remove') and self.remove is not None:
_dict['remove'] = self.remove
if hasattr(self, 'update') and self.update is not None:
_dict['update'] = self.update
return _dict

def _to_dict(self):
Expand Down
6 changes: 0 additions & 6 deletions test/integration/test_iam_access_groups_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,6 @@ def test_create_template(self):
# Construct a dict representation of a RulesActionControls model
rules_action_controls_model = {
'remove': False,
'update': False,
}
# Construct a dict representation of a RuleInput model
rule_input_model = {
Expand All @@ -581,7 +580,6 @@ def test_create_template(self):
assertions_action_controls_model = {
'add': False,
'remove': True,
'update': True,
}
# Construct a dict representation of a AssertionsInput model
assertions_input_model = {
Expand Down Expand Up @@ -690,7 +688,6 @@ def test_create_template_version(self):
# Construct a dict representation of a RulesActionControls model
rules_action_controls_model = {
'remove': True,
'update': True,
}
# Construct a dict representation of a RuleInput model
rule_input_model = {
Expand All @@ -704,7 +701,6 @@ def test_create_template_version(self):
assertions_action_controls_model = {
'add': False,
'remove': True,
'update': True,
}
# Construct a dict representation of a AssertionsInput model
assertions_input_model = {
Expand Down Expand Up @@ -822,7 +818,6 @@ def test_update_template_version(self):
# Construct a dict representation of a RulesActionControls model
rules_action_controls_model = {
'remove': False,
'update': False,
}
# Construct a dict representation of a RuleInput model
rule_input_model = {
Expand All @@ -836,7 +831,6 @@ def test_update_template_version(self):
assertions_action_controls_model = {
'add': False,
'remove': True,
'update': True,
}
# Construct a dict representation of a AssertionsInput model
assertions_input_model = {
Expand Down
Loading