Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Context-Based Restrictions): add Service Ref Target #247

Merged
merged 3 commits into from
Mar 8, 2024
Merged

feat(Context-Based Restrictions): add Service Ref Target #247

merged 3 commits into from
Mar 8, 2024

Conversation

JonahFarc
Copy link
Contributor

PR summary

Add support for new endpoint
Update examples to match the API

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Adds new endpoint for singular service ref target

Does this PR introduce a breaking change?

  • Yes
  • No

soohoowoohoo
soohoowoohoo reviewed Mar 6, 2024
View reviewed changes
Copy link
Member

@soohoowoohoo soohoowoohoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

ibm_platform_services/context_based_restrictions_v1.py Outdated Show resolved Hide resolved
JonahFarc added 3 commits March 7, 2024 14:47
@JonahFarc
feat(Context-Based Restrictions): add Service Ref Target
ddd350c 
Signed-off-by: Dylan <Dylan.Yu@ibm.com>
@JonahFarc
update examples and integration tests for new endpoint
c2bc1a0 
Signed-off-by: Dylan <Dylan.Yu@ibm.com>
@JonahFarc
linting
8d6d9bb 
Signed-off-by: Dylan <Dylan.Yu@ibm.com>
@JonahFarc
Copy link
Contributor Author

@padamstx this is good to be merged

@padamstx padamstx self-assigned this Mar 8, 2024
@padamstx padamstx self-requested a review March 8, 2024 16:23
@JonahFarc
Copy link
Contributor Author

Integration Test Output:
image

Examples Output:
image

padamstx
padamstx approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 8c7742e into IBM:main Mar 8, 2024
3 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Mar 8, 2024
@semantic-release-bot
chore(release): 0.52.0 release notes
d82b910 
# [0.52.0](v0.51.2...v0.52.0) (2024-03-08)

### Features

* **Context-Based Restrictions:** add Service Ref Target ([#247](#247)) ([8c7742e](8c7742e))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.52.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@JonahFarc JonahFarc deleted the cbr_update branch March 8, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soohoowoohoo soohoowoohoo soohoowoohoo left review comments

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JonahFarc @ibm-devx-sdk @soohoowoohoo @padamstx