Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(project): move dependencies to devDependencies #240

Merged
merged 3 commits into from
Mar 26, 2019

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Mar 21, 2019

Addresses part of #177

Move archiver and git-branch to devDependencies.

@vpicone vpicone mentioned this pull request Mar 21, 2019
3 tasks
@vpicone
Copy link
Contributor

vpicone commented Mar 21, 2019

I'm not sure if this would technically be a "breaking change."

@joshblack
Copy link
Contributor Author

@vpicone I think as long as we keep the web-based font files we should be good, and provide a link to download sources 👍

package.json Outdated
"fs-extra": "^7.0.0",
"git-branch": "^2.0.1"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax error here - gotta have a comma at the end of this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akx! That's what I get for editing through GitHub UI 😂

@alisonjoseph alisonjoseph merged commit 9dbbffd into master Mar 26, 2019
@alisonjoseph alisonjoseph deleted the joshblack-patch-1 branch March 26, 2019 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants