Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial OpenTelemetry support #254

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Initial OpenTelemetry support #254

merged 1 commit into from
Jan 9, 2025

Conversation

esnible
Copy link
Member

@esnible esnible commented Jan 9, 2025

Resolves #250

This PR allows PDL to send telemetry to an OpenTelemetry collector.

The PR includes brief documentation describing how to use Jaeger to view traces.

This PR is intended as a minimum viable project of telemetry support. We don't try to generate relationships between multiple LLM calls, or create custom PDL-specific key=value pairs on spans. We don't provide guidelines for using any tracing visualization tools.

Signed-off-by: Ed Snible <snible@us.ibm.com>
@esnible esnible requested a review from vazirim January 9, 2025 19:08
@esnible
Copy link
Member Author

esnible commented Jan 9, 2025

Here is an example showing Jaeger displaying two runs, one where I did not have the Replicate API Key and one where I had the key.

jaeger-pdl

Copy link
Member

@vazirim vazirim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vazirim vazirim merged commit 8a54239 into IBM:main Jan 9, 2025
5 checks passed
@esnible esnible deleted the otel-support-v2 branch January 10, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support OpenTelemetry in PDL interpreter
2 participants