Skip to content

Commit

Permalink
consumer: don't stop the ticker if we time out
Browse files Browse the repository at this point in the history
Now that we reuse a single ticker the whole time, this would probably lead to
the consumer just kind of hanging and never resuming.

Thanks to #1028 (comment) for
catching this.
  • Loading branch information
eapache committed Feb 26, 2018
1 parent 3d1fae1 commit ecf3de7
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion consumer.go
Original file line number Diff line number Diff line change
Expand Up @@ -461,7 +461,6 @@ feederLoop:
child.messages <- msg
}
child.broker.input <- child
expiryTicker.Stop()
continue feederLoop
} else {
// current message has not been sent, return to select
Expand Down

0 comments on commit ecf3de7

Please sign in to comment.