Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to DataDog/zstd breaks Cygwin #1215

Closed
ncastagnoli opened this issue Nov 15, 2018 · 5 comments
Closed

Link to DataDog/zstd breaks Cygwin #1215

ncastagnoli opened this issue Nov 15, 2018 · 5 comments
Labels
cgo-dependency documentation stale Issues and pull requests without any recent activity

Comments

@ncastagnoli
Copy link

Versions

Sarama Version: Checkin e42dc76 and later
Kafka Version: N/A
Go Version: go version go1.9 windows/amd64

Configuration
Logs

$ go build # github.com/mistsys/location/dtest c:\home\nealc\go\pkg\tool\windows_amd64\link.exe: running gcc failed: exit status 1 /usr/lib/gcc/x86_64-pc-cygwin/7.3.0/../../../../x86_64-pc-cygwin/bin/ld: cannot find -lmingwex /usr/lib/gcc/x86_64-pc-cygwin/7.3.0/../../../../x86_64-pc-cygwin/bin/ld: cannot find -lmingw32 collect2: error: ld returned 1 exit status

Problem Description

Data Dog and it's use of embedded "C" is causing some weird issue with "Go" linking the sarama package.

DataDog was added to the Sarama package in e42dc76.

The only resolution I've found is to install mingw, and remove "gcc", which would cause a bunch of issues.

@ncastagnoli
Copy link
Author

Sorry, I wrote the version wrong zstd was added in:

49c4c9a

@prune998
Copy link
Contributor

prune998 commented Apr 3, 2019

Same issue here... Sarama should not include dependencies that embed C code !

@antsbean
Copy link
Contributor

disable CGO, can install on the windows env, please see #1182

@d1egoaz
Copy link
Contributor

d1egoaz commented Aug 22, 2019

nothing we can do right now as this was merged, hopefully we can get rid of cgo in the future.
Also, the zstd support is not working right now :(

@ghost
Copy link

ghost commented Feb 21, 2020

Thank you for taking the time to raise this issue. However, it has not had any activity on it in the past 90 days and will be closed in 30 days if no updates occur.
Please check if the master branch has already resolved the issue since it was raised. If you believe the issue is still valid and you would like input from the maintainers then please comment to ask for it to be reviewed.

@ghost ghost added the stale Issues and pull requests without any recent activity label Feb 21, 2020
@ghost ghost closed this as completed Mar 22, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cgo-dependency documentation stale Issues and pull requests without any recent activity
Projects
None yet
Development

No branches or pull requests

4 participants