Fix build without cgo #1182
Merged
Fix build without cgo #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The github.com/DataDog/zstd library wraps a c library, so it requires cgo to compile. Add zstd wrapper funcs to sarama and put the zstd import behind a build flag requiring cgo. Without cgo, the wrapper funcs return an error saying zstd doesn't work without cgo.
|
Thank you! cc: @bobrik -- could you please 👀 this one too? |
bobrik
approved these changes
Oct 2, 2018
| "errors" | ||
| ) | ||
|
|
||
| var errZstdCgo = errors.New("zstd compression requires building with cgo enabled") |
There was a problem hiding this comment.
Should this error be public?
There was a problem hiding this comment.
I considered that, but I didn't think it would be useful (what is the user going to do differently in this case?). If it were public, we would have to maintain it forever to keep backwards compatibility (e.g. even after switching to a pure-go zstd library).
|
Thanks for the fix, folks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The github.com/DataDog/zstd library wraps a c library, so it requires
cgo to compile. Add zstd wrapper funcs to sarama and put the zstd
import behind a build flag requiring cgo. Without cgo, the wrapper
funcs return an error saying zstd doesn't work without cgo.
Resolves #1179