Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go module support #1272

Closed
ebati opened this issue Feb 7, 2019 · 6 comments
Closed

Go module support #1272

ebati opened this issue Feb 7, 2019 · 6 comments

Comments

@ebati
Copy link
Contributor

ebati commented Feb 7, 2019

CI tests with the latest available packages as it does go get. However, since those versions are not recorded, the versions of dependencies this library is tested against is unknown to users of this library.

Is it OK if I send PR for dependency management with go modules.

@varun06
Copy link
Contributor

varun06 commented Feb 7, 2019

Please do.

1 similar comment
@magicdvd
Copy link

Please do.

@varun06
Copy link
Contributor

varun06 commented Feb 15, 2019

@ebati Are you working on it? If not, I can take a crack sometime in coming week.

@ebati
Copy link
Contributor Author

ebati commented Feb 15, 2019

Actually i prepared go.mod and sum files but i am not sure how to handle go 1.10 which will not able to fetch these version. It might be better to wait 1.12 to come?

@ebati
Copy link
Contributor Author

ebati commented Feb 15, 2019

The issue i am talking about is not about building the code but downloading the appropriate version of dependencies, that is fixed with go.mod, with go 1.10. Since this project does not vendor dependencies and run go get -t on each build running get with 1.10 will get the latest version not the version in go.mod. Please correct me if i am wrong about the matter.

@ebati ebati mentioned this issue Feb 18, 2019
@bai bai closed this as completed in #1282 Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants